refactor(ng-dev): move skills validation command under misc as validate-skills#3806
Open
alan-agius4 wants to merge 1 commit into
Open
refactor(ng-dev): move skills validation command under misc as validate-skills#3806alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the AI-related commands (fix and migrate) from the ng-dev CLI and relocates the skill validation functionality. Specifically, the skills validate command has been renamed to validate-skills and moved under the misc command group, with corresponding updates to build targets, test fixtures, and imports. Feedback on the changes suggests making the builder function in ng-dev/misc/validate-skills/cli.ts synchronous, as yargs does not await asynchronous builders and no async operations are performed within it.
…te-skills Removes the top-level `ai` command and its associated subcommands (`fix`, `migrate`) entirely. Moves the `skills` validator package from `ng-dev/ai/skills` to `ng-dev/misc/validate-skills` and registers it as the `validate-skills` subcommand under `ng-dev misc`. All relative imports and Bazel build dependencies are updated and validated.
alan-agius4
force-pushed
the
validate-skills-command
branch
from
5ef6933 to
b9883a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the top-level
aicommand and its associated subcommands (fix,migrate) entirely.Moves the
skillsvalidator package fromng-dev/ai/skillstong-dev/misc/validate-skillsand registers it as thevalidate-skillssubcommand underng-dev misc. All relative imports and Bazel build dependencies are updated and validated.